Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysql gui #451

Closed
wants to merge 1 commit into from
Closed

Mysql gui #451

wants to merge 1 commit into from

Conversation

amet
Copy link
Contributor

@amet amet commented Sep 29, 2011

ok, this moves MySql DB settings from advancedsettings.xml to GUI under Video/Music Library

@firnsy
I would love your ack for this whole thing, especially the timeout in the first commit

and thx "grumpy" for the patience :)

amet

@davilla
Copy link
Contributor

davilla commented Sep 29, 2011

+1

@JezzX
Copy link
Contributor

JezzX commented Sep 29, 2011

This was discussed in the team forum a while ago and basically was decided

"don't think it should be added to the GUI until there is easy to set up instructions for all the 3 main platforms on the wiki (as well as tweaks to make it run faster) and it can handle images (thumbnails/fanart) as well"

The only things that should be in the UI are things that will also not require other things as well

btw its a post by firnsy under the title "Database (metadata) settings - From AS.xml to the GUI?"

@amet
Copy link
Contributor Author

amet commented Sep 29, 2011

@JezzX

Yeah, I agree but seeing how many users use it on iOS/atv2 platform there really isn't much harm in putting it in GUI.

As for the thumbs, there is a band-aid solution for that until we refactor thumbs and extraction of the existing urls from remote db

@JezzX
Copy link
Contributor

JezzX commented Sep 30, 2011

yeah I know but the thumbnail path substitution still requires editing AS.xml anyway so its kind of pointless to put on in and not the other.
Also from my point of view many "iOS/atv2" users may use it but they do not 'require' it in order for xbmc to work properly so to me its still an advanced setting and spiff, jmarshall, natethomas and Malard all also agreed that it will cause more harm than good in user support

P.S. I bumped the topic int he team forum so go look

@amet
Copy link
Contributor Author

amet commented Sep 30, 2011

As I said, there is a band aid solution for thumb path substitution ...

As for the users support, I can't see how telling an average user to ssh in and use vi to edit as.XML is easier. I actually don't care anymore :) mine is setup, that's all that matters by the looks of things

Bb in a week

@topfs2
Copy link
Contributor

topfs2 commented Oct 4, 2011

I definatly think its a wrong move to put this in the GUI, MySQL is not a good end solution for users and IMO never had. It does do something we need (and many wants) but we need to make a fool proof way of going about this. MySQL is not that way IMO. Remote Database and such is all good but MySQL no. It makes sense to support it but IMO the users which needs it and can handle setting it up can handle setting up the as.xml, the opposite is not true.

Definatly has my -1, our GUI is far to complicated with far to many complicated knobs IMO already.

@Albinoman887
Copy link

i completely agree this is not a good idea at all coming from an end user who CAN edit the as.xml i would not want this in the GUI if you cant edit a as.xml you shouldnt be messing my SQL anyways

@amet
Copy link
Contributor Author

amet commented Oct 4, 2011

Well, it was worth a try... I agree that this is not ideal but it was definitely better than telling someone to edit as.xml

As for not messing with mysql if you can't edit as.xml..... BS, it takes 10 seconds to install it on some systems and it doesn't require any knowledge other than clicking "install" ...

@amet amet closed this Oct 4, 2011
@topfs2
Copy link
Contributor

topfs2 commented Oct 5, 2011

Well thats not really true, you need to move your thumbnails and do path substitution. As I have stated previously if we didn't need to do that I could almost agree it would be valid to have. I still don't like the idea of having a backend which doesn't serve the content aswell (both thumbnails and the actual media) as it just leads to problems for the vast majority of users and does not live up to the quality of the experience we want (IMO)

@amet
Copy link
Contributor Author

amet commented Oct 5, 2011

And I have said more than once that there is a fix for remote thumbs...

@firnsy
Copy link
Contributor

firnsy commented Oct 5, 2011

"... I still don't like the idea of having a backend which doesn't serve the content aswell (both thumbnails and the actual media) as it just leads to problems for the vast majority of users and does not live up to the quality of the experience we want (IMO)"

This would infer that the sqlite/local file system does not live up to the quality of the experience we want (IYO) ;)

I think what the mysql backend has shown is that centralised storage of media/metadata is quickly becoming more of a norm than a niche.

@ghost
Copy link

ghost commented Oct 5, 2011

the idea here was that we already have a whole platform of users using this. we'd stick these in, and a bandaid in the eden release branch to set the substitute crap from the gui. that way we don't have to point atv2 et al users to advancedsettings.xml, which really feels bad.

we all agree this is fugly. but we're exposing it to these users no matter.

@topfs2
Copy link
Contributor

topfs2 commented Oct 5, 2011

"This would infer that the sqlite/local file system does not live up to the quality of the experience we want (IYO) ;)"

Que? On local and sqlite you store the thumbs locally, while they may not be INSIDE the db they are locally so if the db is accessible the thumbs are too (unless something is really wrong). That media needs to be on the server which has the db is a bit overkill I agree though :)

"I think what the mysql backend has shown is that centralised storage of media/metadata is quickly becoming more of a norm than a niche."

I'm not arguing if having media/metadata centralized or distributed is a valid thing, I fully agree it is. MySQL and path substitution is far from the nicest solution to this though. A solution which IMO falls very far from the quality of the rest of XBMC, which is why I'm against it

@cptspiff IMO what we put in gui settings is what we showcase as a fully working and valid feature which is in agreement with our quality standards. While mysql does fill a feature known to be wanted it does not IMO fill the quality (or user experience) standards we have on XBMC.

Somehow I'd feel more comfortable if this was an addon, so you download the addon configure and restart. That might be a little bit more fugly but atleast its outside of what we consider "official" and what we consider in line with our quality standards. It would then be extremely clear its a bandaid solution.

@amet amet reopened this Oct 6, 2011
@bradvido
Copy link

As a heavy mysql user, I agree that for those of us setting up a distributed system, editing the XML and configuring the thumb paths is something we can handle.
This probably shouldn't be in the GUI yet because (as mentioned) it requires configuring things that are outside of XBMC.

What I'd love to see XBMC do is to prompt the user when installing --> Will this be a single instance or a distributed XBMC system? If distributed, ask them what type of database they will be using and configure at that point.

This still leaves the issue of thumbs, but that's a different topic. (I think they should be in the DB and cleaned automatically: http://forum.xbmc.org/showthread.php?t=96097)

@smidley
Copy link

smidley commented Jan 24, 2012

I agree with @bradvido There should be an option during installation. "Enable SQL Database Features" - Don't check this if you're a new user.

@amet amet closed this Jan 26, 2012
HolgerW1 pushed a commit to HolgerW1/xbmc that referenced this pull request Sep 26, 2014
Add fix duplicate shows and fix orphan episodes in MainSanityCheck
amet referenced this pull request in koying/SPMC May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants